Welcome to my talk page. My home page is here:
Any comments on my style are greatly appreciated, both positive and negative.
If you wish to see my old discussions, go here: User:Bellezzasolo/Old_talk
Hi there, and sorry for the "accidential" rollback from me just now.
I don't quite know what to make of your recent flurry of activity. You did lots of categorizing, I see, but also a great many edits that I find to be... arguable. (For example, your adding of Visual Studio to the list of "frequently asnwered things" in Required Knowledge. We generally and strongly suggest to use a GCC cross-compiler setup, and Visual Studio could be considered a second-class citizen in that regard.) The sheer amount of edits from you makes it somewhat difficult to track what you are actually doing.
I won't tell you not to do this, and I certainly welcome any quality edits to the Wiki, so let me just say that I feel uneasy when I see hundreds of edits within a few weeks done by someone with a two-digit post count to the forum. ;-)
Anyway, welcome to OSDev.org. -- Solar 07:40, 20 February 2012 (CST)
- Sorry about the difficulties in analyzing my edits. This problem arises as most of the edits I've made have been correcting little mistakes on the wiki, or improving the source highlighting on certain pages, apart from the categorizing. - Bellezzasolo (Please sign your messages)
I've just rolled back the categorizing of files. A category is meant to link to pages relevant to the subject, not administrative material. The same goes for the templates where I was kindof glad you found another obstacle early (there is a fix for that) for the sake of my own effort. If people are looking for those things, there is the Special:AllPages listing to go to.
On another note, I also plan on merging the SSE pages because there's little to gain by keeping the stubs away from the main page on the subject, and they all look alike. Usually, you'd want someone to enter the search term and land directly at the page with all the relevant info - the difference between versions of SSE matters in that regard. Try to think about making people see what they need to see, and not for indulging some strange idea of perfectionism. (Knowing the difference is probably related to that two-digit post count Solar mentioned earlier - it needs practice)
So far today's tips. One request though is that you use ~~~~ to sign your messages on talkpages so people can immediately see who's on the other end.
- Combuster 13:55, 22 February 2012 (CST)
Quality and appropriateness of code
Apparently, you haven't really understood the point of my criticism over at Printing to Screen. Putting it in a separate page doesn't help. I am sorry for being so blunt, but the quality of your "print" source simply does not satisfy as tutorial / example code.
It's undercommented. It has lots of unwieldly constructs (char null = '\0'???), functions named almost like standard ones that aren't (Puts() and the lack of a newline), it is calling undefined functions (disable() / enable()), it's using global externally visible variables - and goto? I mean, really? I'd probably find more if I cared to look further. That's lots of red ink for 100-something lines of code, and certainly too much for this to reside in our Wiki for others to copy & paste, IMNSHO.
Plus, the overall gist of this Wiki (and the forum) is to not provide ready-made solutions to copy & paste, but to give the information necessary to do it yourself. For example, the information that 0xb8000 is the beginning of video memory is eligible. The information that the first byte is the ASCII code and the second byte is the color is eligible. The information which value in the color byte corresponds to which color is eligible. Links to existing implementations are eligible. Posting code for putc(), puts() and printf() is not eligible. -- Solar 07:02, 23 February 2012 (CST)
Regarding your comments about the use of goto. I am a kernel and hypervisor developer by profession (after doing a hoby OS for longer than I care to admit), and there are many cases where goto is simply the correct solution to a problem. A classic example is for functions which take a spinlock, from which you might otherwise wish to return early. Andyhhp 16:51, 7 August 2012 (CDT)
I agree entirely. One example is my putc() function. I have scrolling code, and before that I write the character to video memory. I use a goto in vertical tabs (and others) to avoid writing the character.--Bellezzasolo 14:41, 10 August 2012 (CDT)
I can think of correct, readable solutions for both scenarios so I don't think they are good examples. In fact, I find the latter to be a very bad one. The use of goto is not bad as long as it doesn't hinder readability, or the code that uses it is produced automatically and not meant to be read by humans (e.g., the output of parser generators). The use of goto is recommended in cases where using anything else would decrease readability (e.g., jumping out of a nested loop, error handling in the absence of exception handling, etc.). --Love4boobies 10:21, 11 August 2012 (CDT)